Code should be refactor in order to make it more easy to update if a …

…new container engine is added
nicolargo · Jan 22, 2023 · b43bf2b · b43bf2b
1 parent 5dd133a
commit b43bf2b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/glances/plugins/glances_docker.py b/glances/plugins/glances_docker.py
@@ -443,12 +443,12 @@ def update_podman(self):
             # Standards stats
             if container_stats['Status'] in ('running', 'paused'):
                 # CPU
-                # '3.21%' to 3.21
+                # Convert: '3.21%' to 3.21
                 container_stats['cpu_percent'] = float(podman_stats[container_stats['IdShort']]['CPU'][:-1])
                 container_stats['cpu'] = {'total': container_stats['cpu_percent']}
                 # MEMORY
-                # @TODO
-                # Should convert 'MemUsage': '352.3kB / 7.836GB' to bytes...
+                # Convert 'MemUsage': '352.3kB / 7.836GB' to bytes
+                # Yes it is ungly but the API do not expose the memory limit in bytes...
                 container_stats['memory'] = {
                     'usage': string_value_to_float(podman_stats[container_stats['IdShort']]['MemUsage'].split(' / ')[0]),
                     'limit': string_value_to_float(podman_stats[container_stats['IdShort']]['MemUsage'].split(' / ')[1]),