Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builds fails against musl: libc::ioctl has different argument types #4

Closed
FauxFaux opened this issue Jun 4, 2019 · 0 comments · Fixed by #5
Closed

Builds fails against musl: libc::ioctl has different argument types #4

FauxFaux opened this issue Jun 4, 2019 · 0 comments · Fixed by #5

Comments

@FauxFaux
Copy link
Contributor

FauxFaux commented Jun 4, 2019 

unfriend% cargo build --target=x86_64-unknown-linux-musl         
   Compiling reflink v0.1.3
error[E0308]: mismatched types
  --> /home/faux/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/reflink-0.1.3/src/sys/unix.rs:21:39
   |
21 |         libc::ioctl(dest.as_raw_fd(), IOCTL_FICLONE, src.as_raw_fd())
   |                                       ^^^^^^^^^^^^^ expected i32, found u64

I happen to be on rustc 1.36.0-nightly (dec4c5201 2019-05-24), Ubuntu x64 host.
FauxFaux added a commit to FauxFaux/reflink that referenced this issue Jun 4, 2019
@FauxFaux
use a local helper macro to evade integer type confusion
2a7528e 
This is relevant on musl, where ioctl() accepts an i32, not a u64,
apparently.

Fixes nicokoch#4.
@FauxFaux FauxFaux mentioned this issue Jun 4, 2019
Merged
@jirutka jirutka mentioned this issue Jun 14, 2022
Open
bczhc added a commit to bczhc/rust that referenced this issue Nov 21, 2022
@bczhc
cow-dedup: change reflink crate to a git revision
e9df2ba 
See:

- nicokoch/reflink#4
- nicokoch/reflink#8
@shandak shandak mentioned this issue Apr 25, 2023
Closed
@elpiel elpiel mentioned this issue Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build on musl FauxFaux/reflink
1 participant
@FauxFaux