Skip to content

Commit

Permalink
[Keyboard] Fix Planck/Rev6 compiler issue (qmk#9953)
Browse files Browse the repository at this point in the history
Specifically, don't want to have both RGBLight and RGB Matrix (with WS2812) enabled at the same time.  This will cause issues in usage, but apparently not when compiling.  Additionally, the led matrix was not encapsulated with preprocessor code.
  • Loading branch information
drashna authored and nicocesar committed Sep 6, 2020
1 parent e9aaf67 commit ef586f5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions keyboards/planck/rev6/rev6.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
#include "rev6.h"

#ifdef RGB_MATRIX_ENABLE
led_config_t g_led_config = { {
// Key Matrix to LED Index
{ NO_LED, 6, NO_LED, NO_LED, 5, NO_LED },
Expand All @@ -33,6 +34,7 @@ led_config_t g_led_config = { {
LED_FLAG_ALL, LED_FLAG_ALL, LED_FLAG_ALL, LED_FLAG_ALL, LED_FLAG_ALL,
LED_FLAG_ALL, LED_FLAG_ALL, LED_FLAG_ALL, LED_FLAG_ALL
} };
#endif

void matrix_init_kb(void) {
matrix_init_user();
Expand Down
3 changes: 1 addition & 2 deletions keyboards/planck/rev6/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ API_SYSEX_ENABLE = no

# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend
#SLEEP_LED_ENABLE = yes # Breathing sleep LED during USB suspend

RGB_MATRIX_ENABLE = WS2812
# RGB_MATRIX_ENABLE = WS2812
# SERIAL_LINK_ENABLE = yes
ENCODER_ENABLE = yes
DIP_SWITCH_ENABLE = yes
Expand Down

0 comments on commit ef586f5

Please sign in to comment.