Skip to content

Commit

Permalink
ZTS: speed up rsend tests
Browse files Browse the repository at this point in the history
With some minor tweaks several of rsend tests can be sped up
considerably without significantly reducing test coverage.

* send-c_verify_ratio:  ~120s -> ~60s
* send_realloc_*_files: ~330s -> ~65s

For the send_realloc* tests this also has the advantage of removing
(most of) the linux/freebsd conditional logic.  Note that for this
test more passes, and thus more incremental send/recvs, are preferable
to a larger number of files.

Total run time of the rsend test group was reduced from roughly 20 to
11 minutes in an environment similar to what's used by the CI.

Reviewed-by: Tony Nguyen <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12876
  • Loading branch information
behlendorf authored and nicman23 committed Aug 22, 2022
1 parent 4c55ec0 commit 6ae58ba
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ log_assert "Verify send -c streams are compressed"
log_onexit cleanup_pool $POOL2

typeset sendfs=$POOL2/$FS
typeset megs=128
typeset megs=64

for prop in "${compress_prop_vals[@]}"; do
for compressible in 'yes' 'no'; do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,8 @@ if is_kmemleak; then
# to avoid timeout due to reduced performance.
nr_files=100
passes=2
elif is_freebsd; then
# Use fewer files and passes on FreeBSD to avoid timeout.
nr_files=500
passes=2
else
nr_files=1000
nr_files=300
passes=3
fi

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,8 @@ if is_kmemleak; then
# to avoid timeout due to reduced performance.
nr_files=100
passes=2
elif is_freebsd; then
# Use fewer passes and files on FreeBSD to avoid timeout.
nr_files=500
passes=2
else
nr_files=1000
nr_files=300
passes=3
fi

Expand Down

0 comments on commit 6ae58ba

Please sign in to comment.