Skip to content

Commit

Permalink
libzfs_sendrecv: Style pass on dump_filesystems
Browse files Browse the repository at this point in the history
* Add a high level comment.
* Eliminate unnecessarily void arg.
* Capitalize and punctuate complete sentences in comments.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#12967
  • Loading branch information
Ryan Moeller authored and nicman23 committed Aug 22, 2022
1 parent 8a05bb8 commit 2382bff
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions lib/libzfs/libzfs_sendrecv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1270,10 +1270,12 @@ dump_filesystem(zfs_handle_t *zhp, send_dump_data_t *sdd)
return (rv);
}

/*
* Send all snapshots for all filesystems in sdd.
*/
static int
dump_filesystems(zfs_handle_t *rzhp, void *arg)
dump_filesystems(zfs_handle_t *rzhp, send_dump_data_t *sdd)
{
send_dump_data_t *sdd = arg;
nvpair_t *fspair;
boolean_t needagain, progress;

Expand Down Expand Up @@ -1326,7 +1328,7 @@ dump_filesystems(zfs_handle_t *rzhp, void *arg)
if (parent_guid != 0) {
parent_nv = fsavl_find(sdd->fsavl, parent_guid, NULL);
if (!nvlist_exists(parent_nv, "sent")) {
/* parent has not been sent; skip this one */
/* Parent has not been sent; skip this one. */
needagain = B_TRUE;
continue;
}
Expand All @@ -1338,7 +1340,7 @@ dump_filesystems(zfs_handle_t *rzhp, void *arg)
if (origin_nv != NULL &&
!nvlist_exists(origin_nv, "sent")) {
/*
* origin has not been sent yet;
* Origin has not been sent yet;
* skip this clone.
*/
needagain = B_TRUE;
Expand All @@ -1361,7 +1363,7 @@ dump_filesystems(zfs_handle_t *rzhp, void *arg)
goto again;
}

/* clean out the sent flags in case we reuse this fss */
/* Clean out the sent flags in case we reuse this fss. */
for (fspair = nvlist_next_nvpair(sdd->fss, NULL); fspair;
fspair = nvlist_next_nvpair(sdd->fss, fspair)) {
nvlist_t *fslist;
Expand Down

0 comments on commit 2382bff

Please sign in to comment.