Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvement for Kafka #31

Merged
merged 1 commit into from
May 13, 2024
Merged

Minor improvement for Kafka #31

merged 1 commit into from
May 13, 2024

Conversation

LHozzan
Copy link
Contributor

@LHozzan LHozzan commented May 13, 2024

  • remove workaround for problem with image
  • rename port name to be better suited with Kafka
  • minor improvement for check_job init script
  • fix minor bugs
    • hardcoded NS in variable KAFKA_CFG_ADVERTISED_LISTENERS
    • default value for extraEnvs in OpenSearch Dashboards

nickytd
nickytd approved these changes May 13, 2024
View reviewed changes
Copy link
Owner

@nickytd nickytd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nickytd nickytd merged commit b2af206 into nickytd:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytd nickytd nickytd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LHozzan @nickytd