Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency to angular 5 #52

Closed
HarelM opened this issue Nov 30, 2017 · 1 comment · Fixed by #54
Closed

Update dependency to angular 5 #52

HarelM opened this issue Nov 30, 2017 · 1 comment · Fixed by #54
Assignees
@nicky-lenaers
Labels
priority: medium type: feature

Comments

@HarelM
Copy link

HarelM commented Nov 30, 2017

Hi,

Current package shows an npm warning when installed with angular 5.0.
Can the dependency be updated?

npm WARN @nicky-lenaers/[email protected] requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself.
@HarelM HarelM changed the title update dependency to angular 5 Update dependency to angular 5 Nov 30, 2017
@nicky-lenaers
Copy link
Owner

Will do. Other issues will be resolved soon as well.

@nicky-lenaers nicky-lenaers self-assigned this Dec 2, 2017
@nicky-lenaers nicky-lenaers mentioned this issue Dec 2, 2017
Merged
nicky-lenaers pushed a commit that referenced this issue Dec 3, 2017
feat(module): Support for Angular 5 (#54)
fe1da1f 
Both Angular 4 and Angular 5 are now supported.

This closes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicky-lenaers nicky-lenaers

Labels
priority: medium type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(module): Support for Angular 5 nicky-lenaers/ngx-scroll-to
2 participants
@nicky-lenaers @HarelM