Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added in some automation and testing that might make it faster + easier to review the currently open PRs in this project. It might be good to start adding tests to the project to verify the correctness and prevent regressions.
Adds
pytest
for testing (seems easiest to use + good docs and examples)Write basic integration type test based off
smogn_example_1_beg.ipynb
. Could be useful to detect basic regressions but further tests needed to guarantee correctness on the basis of the actual algorithm substance. Only 1/3 examples are executed but it at least sets up the framework for automated testing of this library 😬Setup simple test + setup execution through Makefile; eg: just run
make test
to fire off tests... could be useful to create a GH Action in the future to build, package, and upload the repo automatically onmain
pushesAdds rudimentary GitHub Actions (adapted from official example) automation to run tests that runs automatically on branch push, using matrix builds for all currently supported Python versions. Might be worth looking into tox for doing this locally though...
Create
requirements.txt
with proper version freezing (per numpy, pandas in roughly April 2020) for pip in order to use dependency resolution when installing via pip.Removed deprecated fields in
setup.py