Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
naive implementation
Browse files Browse the repository at this point in the history
nickgerrets committed Apr 3, 2024

Verified

This commit was signed with the committer’s verified signature.
1 parent 5345a49 commit 67d27a3
Showing 4 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions src/common/arrow/arrow_appender.cpp
Original file line number Diff line number Diff line change
@@ -163,6 +163,9 @@ static void InitializeFunctionPointers(ArrowAppendData &append_data, const Logic
case LogicalTypeId::UBIGINT:
InitializeAppenderForType<ArrowScalarData<uint64_t>>(append_data);
break;
case LogicalTypeId::UHUGEINT:
InitializeAppenderForType<ArrowScalarData<uhugeint_t>>(append_data);
break;
case LogicalTypeId::FLOAT:
InitializeAppenderForType<ArrowScalarData<float>>(append_data);
break;
3 changes: 3 additions & 0 deletions src/common/arrow/arrow_converter.cpp
Original file line number Diff line number Diff line change
@@ -124,6 +124,9 @@ void SetArrowFormat(DuckDBArrowSchemaHolder &root_holder, ArrowSchema &child, co
case LogicalTypeId::HUGEINT:
child.format = "d:38,0";
break;
case LogicalTypeId::UHUGEINT:
child.format = "d:38,0";
break;
case LogicalTypeId::DOUBLE:
child.format = "g";
break;
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ class TestArrowREE(object):
@pytest.mark.parametrize('size', [100, 10000])
@pytest.mark.parametrize(
'value_type',
['UTINYINT', 'USMALLINT', 'UINTEGER', 'UBIGINT', 'TINYINT', 'SMALLINT', 'INTEGER', 'BIGINT', 'HUGEINT'],
['UTINYINT', 'USMALLINT', 'UINTEGER', 'UBIGINT', 'UHUGEINT', 'TINYINT', 'SMALLINT', 'INTEGER', 'BIGINT', 'HUGEINT'],
)
def test_arrow_run_end_encoding_numerics(self, duckdb_cursor, query, run_length, size, value_type):
if value_type == 'UTINYINT':
1 change: 1 addition & 0 deletions tools/pythonpkg/tests/fast/arrow/test_filter_pushdown.py
Original file line number Diff line number Diff line change
@@ -169,6 +169,7 @@ class TestArrowFilterPushdown(object):
'USMALLINT',
'UINTEGER',
'UBIGINT',
'UHUGEINT',
'FLOAT',
'DOUBLE',
'HUGEINT',

0 comments on commit 67d27a3

Please sign in to comment.