Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old compatibility #46

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

pablobm
Copy link
Contributor

@pablobm pablobm commented Mar 25, 2021

#44 would introduce a change not compatible with Administrate versions prior to v0.15. In the comments, @nickcharlton accepted this breakage.

However, we currently have other code that exists for back-compatibility reasons. If we are going to break compatibility, we should remove code that preserves compatibility in places while other places have lost it.

In this specific PR, I'm removing code that preserves compatibility with versions of Administrate prior to v0.10, as these wouldn't make sense any more.

Once this is merged, #44 will make more sense to be merged too.

Copy link
Owner

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Would you mind looking into the test failure (no defined method hour for 1)? I cannot read.

pablobm added 3 commits April 16, 2021 13:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nickcharlton nickcharlton force-pushed the remove-old-compatibility branch from 8726127 to a757938 Compare April 16, 2021 12:27
@nickcharlton nickcharlton merged commit a101662 into nickcharlton:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants