Skip to content

Commit

Permalink
[Impeller] disable AHB swapchains on all platforms. (flutter/engine#5…
Browse files Browse the repository at this point in the history
…7213)

Disabling until we figure out if we can even use this.
  • Loading branch information
jonahwilliams authored Dec 16, 2024
1 parent 0bc174d commit 481ee0e
Showing 1 changed file with 0 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,31 +56,6 @@ std::shared_ptr<SwapchainVK> SwapchainVK::Create(
return nullptr;
}

// TODO(147533): AHB swapchains on emulators are not functional.
auto& context_vk = ContextVK::Cast(*context);
const auto emulator = context_vk.GetDriverInfo()->IsEmulator();
const auto should_disable_sc =
context_vk.GetShouldDisableSurfaceControlSwapchain();

// Try AHB swapchains first.
if (!emulator && AHBSwapchainVK::IsAvailableOnPlatform() &&
!android::ShadowRealm::ShouldDisableAHB() && !should_disable_sc) {
auto ahb_swapchain = std::shared_ptr<AHBSwapchainVK>(new AHBSwapchainVK(
context, //
window.GetHandle(), //
surface, //
window.GetSize(), //
enable_msaa //
));

if (ahb_swapchain->IsValid()) {
return ahb_swapchain;
} else {
VALIDATION_LOG
<< "Could not create AHB swapchain. Falling back to KHR variant.";
}
}

// Fallback to KHR swapchains if AHB swapchains aren't available.
return Create(context, std::move(surface), window.GetSize(), enable_msaa);
}
Expand Down

0 comments on commit 481ee0e

Please sign in to comment.