Refactor to make testing easier #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-fields
force-pushed
the
nrf/more-tests
branch
from
40b74c9 to
3e77775
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=========================================
+ Coverage 1.38% 2.61% +1.22%
=========================================
Files 2 3 +1
Lines 144 153 +9
Branches 48 50 +2
=========================================
+ Hits 2 4 +2
- Misses 131 137 +6
- Partials 11 12 +1 |
…rather than each individual job
…rather than each individual job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly just extracts the various parts of index.ts out into separate files to make testing easier with no change to functionality. It also further splits up the existing "integration" workflow tests.