Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a possible fix for #84 and #76, use
spawn
rather thanexec
to run commands after @tstackhouse found that exec wasn't great at handling large outputs due to its use of buffering. Spawn is much more efficient because it streams output.Tested this locally with 1000MiB of output using @LukeShu very helpful repro script and after a very long wait, it exited as expected. Added a test of 100MiB to CI to ensure this continues working.