Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next links clicked on the "not found" page cause the route to change but the UI stays on the not found page #64

Merged
merged 23 commits into from
Mar 4, 2024

Conversation

nicholeuf
Copy link
Owner

@nicholeuf nicholeuf commented Mar 3, 2024

Resolves #65

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-site-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 3:58pm

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (49e8396) to head (21ea98b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   99.75%   99.76%           
=======================================
  Files          46       49    +3     
  Lines         412      425   +13     
  Branches       39       42    +3     
=======================================
+ Hits          411      424   +13     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 3, 2024

✅ Meticulous spotted zero visual differences across 125 screens tested: view results.

Last updated for commit 21ea98b. This comment will update as new commits are pushed.

@nicholeuf nicholeuf changed the title use a MUI link so that the page is fully refreshed Not Found "Home Page" doesn't consistently behave properly Mar 4, 2024
@nicholeuf nicholeuf self-assigned this Mar 4, 2024
@nicholeuf nicholeuf changed the title Not Found "Home Page" doesn't consistently behave properly Next links clicked on the "not found" page cause the route to change but the UI stays on the not found page Mar 4, 2024
@nicholeuf nicholeuf marked this pull request as ready for review March 4, 2024 15:51
Copy link
Owner Author

@nicholeuf nicholeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving forward with this change and will put in an issue with the nextjs library.

@@ -19,7 +19,7 @@
"@sentry/nextjs": "^7.102.0",
"@vercel/analytics": "^1.2.0",
"@vercel/speed-insights": "^1.0.10",
"next": "^14.1.0",
"next": "^14.1.1",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading fixed behavior for all links except the homepage (/). The related fix is vercel/next.js#62033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next links clicked on the "not found" page cause the route to change but the UI stays on the not found page
1 participant