-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next links clicked on the "not found" page cause the route to change but the UI stays on the not found page #64
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 99.75% 99.76%
=======================================
Files 46 49 +3
Lines 412 425 +13
Branches 39 42 +3
=======================================
+ Hits 411 424 +13
Misses 1 1 ☔ View full report in Codecov by Sentry. |
✅ Meticulous spotted zero visual differences across 125 screens tested: view results. Last updated for commit 21ea98b. This comment will update as new commits are pushed. |
This reverts commit cbf28be.
…on rather than calling useTheme separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving forward with this change and will put in an issue with the nextjs library.
@@ -19,7 +19,7 @@ | |||
"@sentry/nextjs": "^7.102.0", | |||
"@vercel/analytics": "^1.2.0", | |||
"@vercel/speed-insights": "^1.0.10", | |||
"next": "^14.1.0", | |||
"next": "^14.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading fixed behavior for all links except the homepage (/
). The related fix is vercel/next.js#62033
Resolves #65
/
😞 .