MAS-121 Clean up and add mailcontroller tests

lambda/MAS.Tests/IntergrationTests/DailyEmailTests.cs

@@ -0,0 +1,154 @@
+using MailChimp.Net.Core;
+using MailChimp.Net.Interfaces;
+using MailChimp.Net.Models;
+using MAS.Models;
+using MAS.Services;
+using MAS.Tests.Infrastructure;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Mvc.Controllers;
+using Microsoft.AspNetCore.Mvc.ViewFeatures;
+using Microsoft.AspNetCore.Routing;
+using Microsoft.Extensions.Logging;
+using Moq;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using System.Web.Mvc;
+using Xunit;
+using Source = MAS.Models.Source;
+
+namespace MAS.Tests.IntergrationTests
+{
+    public class FakeController : Microsoft.AspNetCore.Mvc.Controller
+    {
+
+    }
+
+    public class DailyEmailTests : TestBase
+    {
+        IMailService MailService;
+
+        public DailyEmailTests(IMailService mailService)
+        {
+
+            MailService = mailService;
+        }
+
+        public override void Dispose()
+        {
+
+        }
+
+        Item exampleItem = new Item()
+        {
+            Id = "123",
+            Title = "Some Title",
+            Slug = "abc",
+            ShortSummary = "Some short summary",
+            ResourceLinks = "",
+            Comment = "",
+            Specialities = new List<Speciality>
+                {
+                    new Speciality()
+                    {
+                        Key = "1a",
+                        Title = "Some speciality",
+
+                    }
+                },
+            EvidenceType = new EvidenceType()
+            {
+                Key = "1b",
+                Title = "Some evidence type"
+            },
+            Source = new Source()
+            {
+                Id = "1c",
+                Title = "Some source"
+            }
+        };
+        Item exampleItem2 = new Item()
+        {
+            Id = "123",
+            Title = "Some Title",
+            Slug = "abc",
+            ShortSummary = "Some short summary",
+            ResourceLinks = "",
+            Comment = "",
+            Specialities = new List<Speciality>
+            {
+                    new Speciality()
+                    {
+                        Key = "1a",
+                        Title = "Some speciality 2",
+
+                    }
+            },
+            EvidenceType = new EvidenceType()
+            {
+                Key = "1c",
+                Title = "Some evidence type 2"
+            },
+            Source = new Source()
+            {
+                Id = "1c",
+                Title = "Some source"
+            }
+        };
+
+        //[Fact]
+        //public void CanCreateSingleItemEmail()
+        //{
+
+        //    var items = new List<Item> { exampleItem };
+        //    var actualHtml = this.MailService.CreateDailyEmailBody(items, mockController.Object);
+
+        //    actualHtml.ShouldMatchApproved();
+
+        //}
+
+        //[Fact]
+        //public void CanCreateEmailWithTwoItemsSharingEvidenceType()
+        //{
+        //    var items = new List<Item> { exampleItem, exampleItem };
+        //    var actualHtml = this.MailService.CreateDailyEmailBody(items, new FakeController());
+
+        //    actualHtml.ShouldMatchApproved();
+
+        //}
+
+        //[Fact]
+        //public void CanCreateEmailWithTwoItemsDifferentEvidenceType()
+        //{
+        //    var items = new List<Item> { exampleItem, exampleItem2 };
+        //    var actualHtml = "";
+        //    try
+        //    {
+        //        actualHtml = this.MailService.CreateDailyEmailBody(items, new FakeController());
+        //    }
+        //    catch(Exception e)
+        //    {
+        //        var p = e.Message;
+        //    }
+
+
+        //    actualHtml.ShouldMatchApproved();
+
+        //}
+
+        //[Fact]
+        //public void ItemsWithManySpecialitiesRenderCorrectly()
+        //{
+        //    exampleItem.Specialities.Add(new Speciality() { Key = "abcd", Title = "Another speciality" });
+        //    var items = new List<Item> { exampleItem };
+        //    var actualHtml = this.MailService.CreateDailyEmailBody(items, new FakeController());
+
+        //    actualHtml.ShouldMatchApproved();
+
+        //}
+
+    }
+}

lambda/MAS.Tests/UnitTests/Controllers/MailControllerTests.cs

@@ -0,0 +1,63 @@
+using MAS.Controllers;
+using MAS.Models;
+using MAS.Services;
+using Microsoft.Extensions.Logging;
+using Moq;
+using Shouldly;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace MAS.Tests.UnitTests.Controllers
+{
+    public class MailControllerTests
+    {
+        [Fact]
+        public async void GetDailyItemsForToday()
+        {
+
+            var mockContentService = new Mock<IContentService>();
+            var mailService = new MailController(Mock.Of<IMailService>(), mockContentService.Object, Mock.Of<IViewRenderer>(), Mock.Of<ILogger<MailService>>());
+
+            //Act
+            await mailService.PutMailAsync();
+
+            //Assert
+            mockContentService.Verify(mock => mock.GetDailyItemsAsync(null), Times.Once());
+        }
+
+        [Fact]
+        public async void GetDailyItemsForSpecificDate()
+        {
+            DateTime date = new DateTime(2020, 1, 15);
+            var mockContentService = new Mock<IContentService>();
+            var mailService = new MailController(Mock.Of<IMailService>(), mockContentService.Object, Mock.Of<IViewRenderer>(), Mock.Of<ILogger<MailService>>());
+
+            //Act
+            await mailService.PutMailAsync(date);
+
+            //Assert
+            mockContentService.Verify(mock => mock.GetDailyItemsAsync(date), Times.Once());
+        }
+
+        [Fact]
+        public async void RendersDailyViewWithContentItems()
+        {
+            var items = new List<Item>() { }.AsEnumerable();
+            var mockContentService = new Mock<IContentService>();
+            mockContentService.Setup(x => x.GetDailyItemsAsync(null)).ReturnsAsync(items);
+
+            var mockViewRenderer = new Mock<IViewRenderer>();
+
+            var mailController = new MailController(Mock.Of<IMailService>(), mockContentService.Object, mockViewRenderer.Object, Mock.Of<ILogger<MailService>>());
+
+            //Act
+            await mailController.PutMailAsync();
+
+            //Assert
+            mockViewRenderer.Verify(mock => mock.RenderViewAsync(mailController, "~/Views/MAD.cshtml", items, false), Times.Once());
+        }
+    }
+}

lambda/MAS.Tests/UnitTests/MailServiceTests.cs → lambda/MAS.Tests/UnitTests/Services/MailServiceTests.cs

@@ -29,7 +29,7 @@ public void CreateCampaignAndSendToMailChimp()
             var mailService = new MailService(mockMailChimpManager.Object, mockLogger.Object);
 
             //Act
-            var response = mailService.CreateAndSendCampaignAsync("Test Subject", "Preview Text", "Body Text");
+            var response = mailService.CreateAndSendDailyAsync("Test Subject", "Preview Text", "Body Text");
 
             //Assert
             response.Exception.ShouldBe(null);
@@ -51,7 +51,7 @@ public void ErrorInSendingCampaignShouldThrowError()
             var mailService = new MailService(mockMailChimpManager.Object, mockLogger.Object);
 
             //Act + Assert
-            Should.Throw<Exception>(() => mailService.CreateAndSendCampaignAsync("Test Subject", "Preview Text", "Body Text"));
+            Should.Throw<Exception>(() => mailService.CreateAndSendDailyAsync("Test Subject", "Preview Text", "Body Text"));
         }
     }
 }