Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on Linux RT will be properly skipped if version of LabVIEW is < 2018 #29

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

mdcerna
Copy link
Contributor

@mdcerna mdcerna commented Mar 25, 2019

Fixes #18

What does this Pull Request accomplish?

Fixed tests so they are properly skipped if version of LabVIEW is < 2018 using string global to constants.vi.
Updated testExample.vit for future test creation.

Why should this Pull Request be merged?

See above.

What testing has been done?

2015: Linux RT tests are automatically reported as Skipped.
2018: Linux RT tests run successfully.

…al to constants.vi.

Updated testExample.vit for future test creation.
@ni ni deleted a comment from niveristand-diff-bot Mar 26, 2019
Copy link
Contributor

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename the new control in Constants.vi from MinVersion2018 to something like MinPxiLinuxRtVersion.

@mdcerna mdcerna merged commit da8107c into master Mar 26, 2019
@mdcerna mdcerna deleted the dev/minVersionOnLinux branch March 26, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants