Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors from Refresh Modules calls #215

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

Karl-G1
Copy link
Contributor

@Karl-G1 Karl-G1 commented Aug 22, 2022

What does this Pull Request accomplish?

Ignore errors from Refresh Modules calls by default

Why should this Pull Request be merged?

With some third-party EtherCAT devices' ESI files on disk and connected to the RT target, the RT VI Refresh Modules returns an error. This prevents both Auto-Detect and deployment from succeeding, even though the variables were successfully returned from the target.

This should be a relatively harmless change, and it enables at least one particular EtherCAT device to successfully detect and deploy.

What testing has been done?

Hand-testing with VeriStand 2020 R6 using the 21.5 RT feed

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

SEECD Engine.lvlib--Get Master and Local Mod IOVs.vi.png

capture

SEECD System Explorer.lvlib--Host - Refresh All.vi.png

capture

@Karl-G1 Karl-G1 merged commit 8448df5 into main Aug 23, 2022
@Karl-G1 Karl-G1 deleted the dev/ignore_refresh_errors branch August 23, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants