Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependent PPLs from project #15

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Remove dependent PPLs from project #15

merged 1 commit into from
Aug 21, 2019

Conversation

buckd
Copy link
Collaborator

@buckd buckd commented Aug 21, 2019

What does this Pull Request accomplish?

There is a JKI VI Tester bug where tests cannot be run from the UI if PPLs contain lvlibs. The SLSCSwitchMessagingLibrary.lvllipb contains SLSC Switch.lvlib, which means we hit this bug.

This change lets us run tests from the UI and ensures dependent PPLs are built to the proper location.

Why should this Pull Request be merged?

We want to run the VI Tester from the UI as developers to validate changes before committing pull requests.

What testing has been done?

Built locally to ensure same file output structure.
Built with VIs using the PPLs to verify they are copied to the correct location in the build output.

There is a bug with JKI VI Tester where tests cannot be run
from the UI if PPLs contain lvlibs.

This change lets us run tests from the UI and ensures dependent PPLs are built to the proper location.
@buckd buckd requested review from rtzoeller and mdcerna August 21, 2019 15:05
@buckd buckd requested a review from csjall as a code owner August 21, 2019 15:05
@buckd buckd merged commit 6e4ce2c into master Aug 21, 2019
@buckd buckd deleted the dev/ppl-build-changes branch August 21, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants