Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing pharlab from active config #183

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

mraj8370-NI
Copy link
Contributor

@mraj8370-NI mraj8370-NI commented Sep 6, 2024

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

This PR will fix the intermittent FPGA Addon test failure.

Why should this Pull Request be merged?

FPGA add-on no longer support pharlab and this PR will remove pharlab from active configuration.

What testing has been done?

image

@mraj8370-NI mraj8370-NI requested a review from Raagul-s September 6, 2024 08:14
@mraj8370-NI mraj8370-NI removed the request for review from skolthay September 6, 2024 08:14
Copy link
Contributor

@Raagul-s Raagul-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same for all the target.ini files and make sure to validate all the unit tests.

@mraj8370-NI mraj8370-NI merged commit 85c0e05 into main Sep 11, 2024
7 checks passed
@Raagul-s Raagul-s deleted the users/miraj/fixing-test-case branch September 20, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants