Fixed FXP data conversion issue #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. FPGA Register IO.lvlib--Read FXP.vi.png
FPGA Register IO.lvlib--Write FXP.vi.png
|
buckd
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
FPGA addon CD doesn’t handle FXP data type conversion properly; it works only for FXP(8, 16, 32, 64) bit word lengths. For remaining word lengths, it converts data to some junk values.
Required logical bit shift logic is included in both
Read & Write FXP VIsto support all FXP word length.Why should this Pull Request be merged?
Including this changes will allow FPGA addon CD to support FXP data type of all word length.
What testing has been done?
Build the CD on local PC & tested it by deploying bit file with different FXP word length (FXP 48,16).