Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias details for RIO Device Address in Help and QSG #150

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Add alias details for RIO Device Address in Help and QSG #150

merged 2 commits into from
Mar 17, 2022

Conversation

PaulDanH
Copy link
Collaborator

@PaulDanH PaulDanH commented Mar 10, 2022 •
edited
Loading

What does this Pull Request accomplish?

  • Adds details in Main Page help and QSG regarding the use of aliases for RIO Device field.

Why should this Pull Request be merged?

  • FPGA Addon supports aliases in the RIO Device address field and we should advertise this for our users.

What testing has been done?

  • Using a PXI target with R Series boards (PXIe-7868R, PXIe-7858R and PXIe-7822R), different configurations were tested in VeriStand 2019 and VeriStand 2021 to make sure aliases work as expected and the bitfiles run in the VeriStand context.

@PaulDanH PaulDanH requested a review from DStavilaNI as a code owner March 10, 2022 13:54
@PaulDanH PaulDanH removed the request for review from DStavilaNI March 10, 2022 13:55
@PaulDanH
Copy link
Collaborator Author

Hey @WillCawley, can you review this change for us? It seems that I cannot add you directly as a reviewer. Thanks!

WillCawley
WillCawley suggested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@WillCawley WillCawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phutanu Had a few suggestions. Review them and I think you are good to go.

@PaulDanH PaulDanH requested a review from Karl-G1 March 11, 2022 08:25
@PaulDanH
Copy link
Collaborator Author

@phutanu Had a few suggestions. Review them and I think you are good to go.

@WillCawley feedback implemented. Thanks for the timely help.

Karl-G1
Karl-G1 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@Karl-G1 Karl-G1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated the CHM is updated in the PR build. Looks good.

@Karl-G1 Karl-G1 merged commit 641a211 into ni:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillCawley WillCawley WillCawley requested changes

@Karl-G1 Karl-G1 Karl-G1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulDanH @Karl-G1 @WillCawley