Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip synchronization test if version is older than 2018 #35

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

buckd
Copy link
Collaborator

@buckd buckd commented Jan 29, 2019

What does this Pull Request accomplish?

Skips multi-FPGA synchronization test if running tests in versions prior to 2018.

Why should this Pull Request be merged?

No reason to watch this test fail when running in our dev versions. Fixes #32

What testing has been done?

skippedtest

@buckd buckd requested a review from csjall as a code owner January 29, 2019 20:18
@buckd buckd requested a review from rtzoeller January 29, 2019 20:18
@buckd buckd added enhancement New feature or request multi fpga Work for multiple FPGA support labels Jan 29, 2019
Copy link
Contributor

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@buckd buckd merged commit 0820cb9 into master Jan 30, 2019
@buckd buckd deleted the dev/skip-tests branch January 30, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multi fpga Work for multiple FPGA support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants