Fixes #21 data conversion issue #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault byte order rather than big-endian, since this matches the OS/CPU on all targets supported by the DSF.
… viewing a buffer. Also fixed a small bug where characters from a larger number would still be shown when the value lowers to a smaller value.
…s. Changed the default configuration cluster value on front panel to include some string offsets for converting engine channels to string channels.
ryanpoulos
changed the title
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. DSF Core.lvlib--Data Viewer.vi.png
DSF Core.lvlib--Default Buffer Converter Transfer Configuration.lvclass--Initialize From Settings.vi.png
DSF Core.lvlib--Read Buffer.vi.png
DSF Core.lvlib--Update Values Buffer.vi.png
Framework Test.vi.png
|
|
Many of the changes made here are aligned with changes in PR#22. Because it is G code, the merging of changes is not straightforward. I will schedule a meeting for us to resolve. |
|
|
dbendele
approved these changes
Sep 30, 2020
dbendele
added a commit
that referenced
this pull request
Oct 2, 2020
* set reentrancy and inlining consistent with needs for VIs that need to maintain state for each instance in memory; also use reentrancy to improve parallelization * VI analyzer recommended changes * remove unnecessary layer of subVI * add tests for DSF reentrancy that verify functionality of two parallel instances of framework * separate compiled code from source <AZDO>1097900 https://dev.azure.com/ni/DevCentral/_workitems/edit/1097900 * merge PR#22 changes with PR#24 changes and add unit test for new subVI added in PR #24; changed scope of subVI to public for unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Only makes the above fixes. Does not change core functionality.
What testing has been done?
Ran Framework Test VI.