Add tests for connector pane validation and IP address extraction #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buckd
previously approved these changes
Oct 15, 2018
There was a problem hiding this comment.
Just a minor thing in testAssertConnectoryPanesMatcheExpectedMissingFails.vi. If an error comes out of passIfError.vi, we should stop the for loop. If that happens, neither of the subVI calls in that loop do anything after the first failure because they both check for errors and just pass wires through if there's an error in. Add a conditional terminal and wire error out of passIfErrors.vi to this terminal and I'm good.
One test is failing due to incorrect XPath strings used to pull out ActionVIs
rtzoeller
force-pushed
the
dev/initial_tests
branch
from
1f95efb to
fa7c4ad
Compare
buckd
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add tests for connector pane validation and IP address extraction.
Fix connector pane assert referencing incorrect XPath keys
Why should this Pull Request be merged?
There is currently no test coverage for the testing utilities; this pull request adds tests for the connector pane validation which has historically been a pain point.
Also includes a fix for some VI connector panes not being checked properly due to incorrect XPath keys.
What testing has been done?
Running the tests produces passing results, and caught a bug.