Mark tests requiring hardware as system tests #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karl-G1
changed the title
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. testExample 1.vi.png
VeriStandTestCaseSystemTests.lvclass--setUp.vi.png
VeriStandTestCaseSystemTests.lvclass--tearDown.vi.png
VeriStandTestCaseSystemTests.lvclass--testBenchmarkSystemDefinitionFails.vi.png
VeriStandTestCaseSystemTests.lvclass--testBenchmarkSystemDefinitionPasses.vi.png
VeriStandTestCaseUnitTests.lvclass--setUp.vi.png
VeriStandTestCaseUnitTests.lvclass--tearDown.vi.png
VeriStandTestCaseUnitTests.lvclass--testGetPropertyFromAddedConfigurationFileWithoutDeploying.vi.png
|
csjall
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR correctly identifies 3 tests in the repo as system tests. Currently, they are labeled as unit tests and execute before the PXI system is imaged during ATS runs. This change marks them as system tests and specifies they run as part of the Pharlap tests on the ATS.
Why should this Pull Request be merged?
This change splits the VeriStandTestCaseTests class into unit and system tests, enabling ATS runs to correctly execute the tests.
What testing has been done?
Manually updated the test system with this branch and successfully executed the tests in 2019.