Allow a subset of terminals for the asynchronous connector panes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. VeriStandTestUtilities.lvlib--AssertConnectorPanesMatchTemplateFiles.vi.png
VeriStandTestUtilities.lvlib--FilterCustomDeviceVIs.vi.png
VeriStandTestUtilities.lvlib--GetCustomDeviceInitializationVI.vi.png
VeriStandTestUtilities.lvlib--GetCustomDevicePageVIs.vi.png
VeriStandTestUtilities.lvlib--GetCustomDeviceRTDriverVIs.vi.png
VeriStandTestUtilities.lvlib--GetCustomDeviceTimingSourceVIs.vi.png
VeriStandTestUtilities.lvlib--GetCustomDeviceXMLVIs.vi.png
|
Karl-G1
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Allow a subset of terminals on the asynchronous RT driver VIs. This is permitted by VeriStand, and we should not fail if some are omitted.
Why should this Pull Request be merged?
This fixes an issue introduced by #50 which broke the test for the NI Synchronization custom device.
What testing has been done?
Ran the unit tests, ran the tests for the NI Synchronization and Scan Engine custom devices.