Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiscoverTestCases operation #38

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Add DiscoverTestCases operation #38

merged 3 commits into from
Apr 18, 2019

Conversation

rtzoeller
Copy link
Contributor

What does this Pull Request accomplish?

Adds a new operation for discovering/enumerating test cases in a repository.

Why should this Pull Request be merged?

We need a way for the test pipeline to discover tests.

What testing has been done?

Hand testing with the LabVIEW CLI

@rtzoeller rtzoeller added the enhancement New feature or request label Apr 18, 2019
@rtzoeller rtzoeller requested a review from csjall as a code owner April 18, 2019 16:17
@rtzoeller rtzoeller requested a review from buckd April 18, 2019 16:17
Copy link
Collaborator

@buckd buckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, I'd say you should use <National Instruments>/Shared/LabVIEW CLI/Operations/Utilities/GetOperationOutput.vi instead of creating your own return code from the error cluster, but even the built-in operations don't all use this, so it's up to you.
image

Copy link
Collaborator

@buckd buckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty complicated. You could just strip the path from the current VI twice to get the folder name (which matches the class name) or you could just hard code it, since the operation name isn't dynamic.
image

@csjall
Copy link
Collaborator

csjall commented Apr 18, 2019

  • The top level VI, RunOperation.vi, is too busy. Look at RunVITester.lvclass:RunOperation.vi for some clean code inspiration. Create a utility method to parse output and simply return results.

image

  • It seems the class name terminal was used for debugging purposes. Removed unwired terminal.

@rtzoeller rtzoeller merged commit 6a112ce into master Apr 18, 2019
@rtzoeller rtzoeller deleted the dev/discovertestcases branch April 18, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants