Keep overridden sysdef in same directory #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. VeriStandTestUtilities.lvlib--GenerateOverriddenSystemDefinition.vi.png
The following VIs could not be diffed:
|
|
It looks like there is a potential race condition in In practice I think this is ok, because I don't expect VeriStand to be constantly re-reading the file from disk, but IMO we should not assume this. |
rtzoeller
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Generates overridden system definition in the same location as the original system definition so any relative paths in the definition can still be located.
Why should this Pull Request be merged?
Tests requiring dependent files will fail to deploy without changes to ensure relative paths in the sysdef are consistent.
What testing has been done?