Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip output from OpenVeriStandConnection so additional code in se… #35

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

buckd
Copy link
Collaborator

@buckd buckd commented Mar 21, 2019

…tUp.vi can be ignored

What does this Pull Request accomplish?

Allows code in test cases using OpenVeriStandConnection.vi to know if the open was skipped so additional code in setUp.vi can be ignored

Why should this Pull Request be merged?

Even if a test is skipped because the minimum version requirement is not met, the rest of the code in setUp.vi will still execute. If an error occurs in that code, the test will show up as failed instead of skipped.

What testing has been done?

Used skipped output to conditionally execute setup code that will error if not skipped.

@buckd buckd requested review from csjall and rtzoeller as code owners March 21, 2019 13:12
@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

The following VIs could not be diffed:

  • C:\jenkins\workspace-device-testing-tools_PR-35-5QAO3GDN67BEMHVKBOLBXIHFA4FOVNTZYX4ISQBGG2XKEEX66WKQ\VeriStandTestCase\OpenVeriStandConnection.vi

@rtzoeller
Copy link
Contributor

I think the diff bot failed because renaming the old VI for diffing is detaching it from the class. Need to investigate possible fixes. Will review manually.

@rtzoeller
Copy link
Contributor

@buckd does it make sense to expose this as a getter instead? I am imagining calling this in setUp.vi, and needing to change my tearDown.vi logic to do less if the test was skipped.

@buckd
Copy link
Collaborator Author

buckd commented Mar 21, 2019

does it make sense to expose this as a getter instead?

Then we're back to re-implementing a field that already exists in VI Tester, but isn't exposed publicly. So far, I haven't really had to change anything in cases where we've skipped. For the case that prompted this particular change, I can just ignore a specific error on close of the bitfile.

@buckd buckd merged commit d1f6131 into master Mar 21, 2019
@buckd buckd deleted the dev/quick-fix branch March 21, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants