Skip tests if the current LV/VeriStand version is older than minimum #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied minimum version.
|
Yes, I'm reimplementing the Skip Test field because the isSkipped field in TestCase.lvclass has no public/protected accessor. |
|
@buckd can you file an issue on the https://github.com/JKISoftware/JKI-VI-Tester repo for the isSkipped problem? I am fine reimplementing it for now, but this seems like a nice improvement to share with others. |
rtzoeller
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Automatically skip tests that cannot be run in older versions of LV/VeriStand. The test will be skipped and the skip message will state that the current version is not compatible with the minimum version of the test.
Why should this Pull Request be merged?
We have tests that can only be run in certain versions and later. Instead of having to know to skip a test or figure out why it failed, we can automatically skip the test and provide a good reason.
What testing has been done?
Ran tests in the default version of LV (2015) with a test that sets a minimum of 2018. All tests ran except the test specifying a minimum; it was skipped. Also ran the test utilities tests to make sure this doesn't break existing tests.
