Fix #15 #16
Merged
Fix #15 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtzoeller
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Ran the SEECD tests with this change and everything looked good in terms of functionality.
I noticed there is an inconsistency in the hierarchy regarding where the unit tests live and their naming. I don't have a preference either way, but we should at least be consistent.
Fix it, then ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] This contribution adheres to CONTRIBUTING.md.
What does this Pull Request accomplish?
Fix broken OpenVeriStandConnection.vi. We changed the utilities without changing the test case.
Why should this Pull Request be merged?
Bug fix
What testing has been done?
Added a test for opening/closing the VeriStand connection. All tests are green.