Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable diff bot #14

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Enable diff bot #14

merged 3 commits into from
Nov 6, 2018

Conversation

rtzoeller
Copy link
Contributor

What does this Pull Request accomplish?

Enable the diff bot by opting in through the Jenkinsfile.

Why should this Pull Request be merged?

We currently are not using the diff bot anywhere; this repo is a good starting point as it does not have an existing Jenkinsfile.

What testing has been done?

This has been tested on a separate repo, and should be built on this one as the pull request is made.

@rtzoeller rtzoeller added the enhancement New feature or request label Nov 1, 2018
@buckd
Copy link
Collaborator

buckd commented Nov 2, 2018

File not found during the diff on build 2 of this PR.

@rtzoeller
Copy link
Contributor Author

It looks like the failure was related to an implicit assumption that the string containing the org, repo, and branch name would contain exactly two forward slashes.

https://github.com/ni/niveristand-custom-device-build-tools/blob/f5aea8eca9e4084fc6f4e8482def9be8bd5e3de1/resources/post_pictures_to_pull_request.py#L56

This obviously fails when branches have forward slashes in them, e.g. with dev/enable-diff-bot. I already have a fix, but I'll spin up a fork to test it on before submitting a pull request.

@rtzoeller rtzoeller closed this Nov 2, 2018
@rtzoeller rtzoeller reopened this Nov 2, 2018
@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

VeriStandTestCase.lvclass--lf9sma_AssertChannelLoopback.vi.png: capture

@rtzoeller
Copy link
Contributor Author

As shown in the comment by @niveristand-diff-bot above, the Jenkinsfile added by this change successfully triggers the diffing functionality.

@rtzoeller rtzoeller requested review from buckd and csjall November 2, 2018 21:21
@rtzoeller rtzoeller merged commit 02881be into master Nov 6, 2018
@rtzoeller rtzoeller deleted the dev/enable-diff-bot branch November 6, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants