-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appearances and update inc/dec for number field #612
Conversation
Similar to the combobox, I would have expected these "button" to be actual buttons with a pressed state & potentially to also be focusable. I'm guessing that is also difficult given the FAST template? |
@mollykreis I think we can actually pass an html template (using Nimble buttons) for the "step-up" and "step-down" glyphs, so I think we could do what you suggest. Do we really want that? I'm not sure it's useful to have the inc/dec "buttons" be keyboard focusable, since you can do the same with the up/down arrows when the input itself is focused. Also, the inc/dec buttons are smaller than the standard button height/width, but I guess we could just size them down. |
@m-akinc, my thought is, yes, that is what we want, but I'm not necessarily the person to officially make that decision. Looking at the XD doc, though, it seems like Brandon used buttons within the component. They have a pressed state in XD. I think we'd want it to be consistent with the combobox, which also uses a smaller-than-standard button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Milan's feedback and don't have anything additional to add.
Pull Request
π€¨ Rationale
Fixes #361
π©βπ» Implementation
Note that the following are still incomplete/does not match the design doc:
π§ͺ Testing
Tested in Storybook
β Checklist