Fix menu accessibility issues #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
requested review from
fredvisser,
jattasNI and
rajsite
as code owners
|
Note: There is still an open discussion in #185 regarding the best approach to fix the issue. This is my recommendation, and since the implementation was small, I decided to move forward with the approach. If the discussion on the issue leads in a different direction, I'll update the PR accordingly. |
|
Closing this per discussion on the associated issue #185. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Related Bug:
👩💻 Implementation
This change introduces a new
nimble-menu-headerelement to be used in place of aheaderin thenimble-menu. This addresses the accessibility issues flagged by storybook.I updated the stories accordingly in storybook.
I also modified the font size & color of the Custom Menu story so that it doesn't have accessibility issues associated with it.
🧪 Testing
Viewed menu in storybook.
✅ Checklist