Add nimble token for toolbar height

[aagash-ni]

Pull Request

🤨 Rationale

Added the Nimble token 40px for toolbar height as it is required in the following areas:

• Rich Text Editor Footer Section: Currently implemented using an internal CSS variable.

• SlToolbarComponent in systemlink-lib-angular: Currently uses an internal CSS variable.

• Schedule Assistant Page Toolbar: A custom implementation is temporarily used to address the blur (mousedown) issue in fast-toolbar for Chrome and Edge browsers. For more details: https://dev.azure.com/ni/DevCentral/_git/Skyline/pullRequest/850146#1733521296

  • Issue link: Toolbar Active control blur/focus-out events not happening when clicking within in Edge and Chrome #2494

👩‍💻 Implementation

• Added 40px height token for toolbar $ni-nimble-toolbar-height.

🧪 Testing

NA

✅ Checklist

• I have updated the project documentation to reflect my changes or determined no changes are needed.

[jattasNI]

Thanks for thinking of trying to single-source this in Nimble. But I have an initial concern: the Nimble toolbar itself would not use this token, so it seems strange to expose it as the "official" toolbar height. My concern with that is that a client would probably expect that they could override the value of this token and have all Nimble toolbars update, but that would not be the case.

The reason the Nimble toolbar wouldn't use this token is that the toolbar sizes itself based on the height of its content plus some vertical padding (32px +2*4px = 40px). I suspect we want to keep that behavior because we may want both shorter and taller toolbars for certain use cases.

Could the use cases you describe follow the same approach and avoid the need for a new token entirely? A downside of that approach is that if we ever change our minds about this behavior (e.g. change the vertical padding) then it would be hard to identify all the places that need to change. But I personally think that's an acceptable risk.

I'm going to mark this as not approved for now but I'm happy to continue the discussion. However, me and the other Nimble reviewers are all going to be OOO for the rest of the year so if you want to continue the conversation it'll have to wait for next year. In the meantime hopefully you can get by with duplicating this value in a few places.