Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blazor and Angular support for the checkbox error state #2484

Merged
merged 18 commits into from
Dec 2, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

Add Blazor and Angular support for the checkbox error state by exposing the errorVisible and errorText properties through the Blazor and Angular component wrappers.

Resolves #2018

👩‍💻 Implementation

Followed existing patterns for adding errorVisible and errorText to the checkbox in Angular and Blazor.

🧪 Testing

Followed existing patterns for unit testing.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite marked this pull request as ready for review December 2, 2024 17:28
@rajsite
Copy link
Member

rajsite commented Dec 2, 2024

bypassing blazor owners for straightforward change @atmgrifter00 @msmithNI

@rajsite rajsite merged commit 939a9e5 into main Dec 2, 2024
14 checks passed
@rajsite rajsite deleted the checkbox-error branch December 2, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error state for nimble-checkbox
2 participants