-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token representing the height of the table with all rows visible #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@atmgrifter00, @rajsite, can you take a look at this draft PR and let me know if you agree with the direction? If so, I'll add some tests for it and update the storybook docs referencing the issue being resolved. |
atmgrifter00
approved these changes
Jul 29, 2024
rajsite
reviewed
Jul 30, 2024
rajsite
reviewed
Aug 9, 2024
rajsite
reviewed
Aug 14, 2024
rajsite
reviewed
Aug 16, 2024
rajsite
reviewed
Aug 16, 2024
rajsite
reviewed
Aug 16, 2024
change/@ni-nimble-components-a5fd15e6-373b-4e3c-b562-fc2e440df26c.json
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 16, 2024
change/@ni-nimble-components-a5fd15e6-373b-4e3c-b562-fc2e440df26c.json
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 19, 2024
mollykreis
changed the title
Add option to the
Add token representing the height of the table with all rows visible
Aug 19, 2024
nimble-table
to have its height automatically determined by the number of rows
mollykreis
commented
Aug 19, 2024
rajsite
approved these changes
Aug 19, 2024
jattasNI
approved these changes
Aug 20, 2024
packages/nimble-components/src/theme-provider/design-token-comments.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 20, 2024
change/@ni-nimble-components-a5fd15e6-373b-4e3c-b562-fc2e440df26c.json
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 20, 2024
change/@ni-nimble-components-a5fd15e6-373b-4e3c-b562-fc2e440df26c.json
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Resolves #1624
👩💻 Implementation
The table already knows the combined height of all the rows in the table because it uses this value to size the
table-scroll
container. Therefore, I was able to create a token that gets assigned a value within the scope of the table styling that has a value of the size of the height the table needs to show all rows. The token's name istableFitRowsHeight
.The table also now sets a default max-height on itself to keep a client from accidentally using
tableFitRowsHeight
and trying to render thousands of rows at once.To use the new token, a client would create their table exactly as before and add the following style:
🧪 Testing
✅ Checklist