Switch to a View Engine based build #209

rajsite · 2021-11-30T00:23:57Z

Pull Request

The change covers TASK 1741883 which is to switch nimble-angular to be a View Engine based build as discussed in the ensuring library version compatibility topic.

This PR also addresses the feedback given in #207.

Change angular-workspace/projects/ni/nimble-angular/tsconfig.lib.prod.json to "enableIvy": false.
Modify the publish step to rebuild the package before publish.
- During the full build angular runs ngcc in the built library package mutating the contents. The library must be rebuilt to a clean state before publish.

Relies on existing test infrastructure.

I have updated the project documentation to reflect my changes or determined no changes are needed. Updated beachball workflow discussion.

package.json

angular-workspace/package.json

rajsite · 2021-11-30T19:57:47Z

@brianehenry I did an override to merge the PR but if you have feedback I can address it in a follow-up

Switch to a View Engine based build

059a13a

rajsite requested review from brianehenry, fredvisser and jattasNI as code owners November 30, 2021 00:23

rajsite commented Nov 30, 2021

View reviewed changes

package.json Show resolved Hide resolved

Change files

3b4d3f8

rajsite mentioned this pull request Nov 30, 2021

Package publishing workflow and Angular packaging update [Retroactive PR] #207

Closed

1 task

jattasNI approved these changes Nov 30, 2021

View reviewed changes

angular-workspace/package.json Show resolved Hide resolved

Merge branch 'main' into view-engine-build

813a313

rajsite enabled auto-merge (squash) November 30, 2021 19:47

rajsite disabled auto-merge November 30, 2021 19:56

rajsite merged commit ca4ee0c into main Nov 30, 2021

rajsite deleted the view-engine-build branch November 30, 2021 19:57