Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height: auto; from the nimble-table in the Angular example app #1660

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

The nimble-table doesn't support being configured with height: auto, so this styling should be removed from the example app. With height: auto, no rows of the table are rendered in the app. See #1624

👩‍💻 Implementation

Remove height: auto from the example app's styling. Now the table uses the default height set in the nimble-table's :host styling. This is aligned with how the Blazor example app is styled.

🧪 Testing

  • Verified the rows of the table are now rendered in the Angular example app

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis marked this pull request as ready for review November 10, 2023 19:24
@rajsite rajsite merged commit 1e887bb into main Nov 10, 2023
12 checks passed
@rajsite rajsite deleted the example-app-table-height branch November 10, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants