Remove height: auto;
from the nimble-table in the Angular example app
#1660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The nimble-table doesn't support being configured with
height: auto
, so this styling should be removed from the example app. Withheight: auto
, no rows of the table are rendered in the app. See #1624👩💻 Implementation
Remove
height: auto
from the example app's styling. Now the table uses the default height set in the nimble-table's:host
styling. This is aligned with how the Blazor example app is styled.🧪 Testing
✅ Checklist