Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text editor | Setting height in storybook docs #1513

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

vivinkrishna-ni
Copy link
Contributor

Pull Request

🤨 Rationale

  1. To provide more spacing and facilitate the exploration of various functionalities of the rich text editor, setting a default height in storybook docs until enabling the fit-to-content attribute.
  2. To make the content, such as the links (Rich text editor & viewer | Support for absolute link #1496 (comment)), visible if any are added as part of the test, height is added for storybook tests.

👩‍💻 Implementation

  1. Add height: 160px; to the rich text editor storybook doc.
  2. Add height for the theme matrix test to isolate the Chromatic test difference from the Rich text editor & viewer | Support for absolute link #1496 PR.

🧪 Testing

Verified manually the differences in the height of the component in storybook docs and tests.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@vivinkrishna-ni vivinkrishna-ni marked this pull request as ready for review September 12, 2023 06:24
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out!

@jattasNI jattasNI merged commit 5f38265 into main Sep 12, 2023
@jattasNI jattasNI deleted the users/vivin/setting-height-in-storybook branch September 12, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants