Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text editor | Fix for updating "tabindex" of button in toolbar when clicking on the icon #1503

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Rich text editor | Fix for updating "tabindex" of button in toolbar when clicking on the icon #1503

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eec220a
Adding pointer-events: none to toggle-buttons in toolbar
vivinkrishna-ni Sep 8, 2023
e50de64
Change files
vivinkrishna-ni Sep 8, 2023
ff8f38c
Change file
vivinkrishna-ni Sep 8, 2023
7fb2c35
Merge branch 'main' into users/vivin/fix-for-other-button-focus
vivinkrishna-ni Sep 8, 2023
5d31d4f
Added test case to check if the tab index gets updated on icon click
vivinkrishna-ni Sep 8, 2023
e7227dd
Fix lint
vivinkrishna-ni Sep 8, 2023
3f15463
Reverting back the test cases
vivinkrishna-ni Sep 8, 2023
0d865d2
Updated the test case to check the slot containing icon
vivinkrishna-ni Sep 8, 2023
3af1a01
Adding placeholder comment for this styling
vivinkrishna-ni Sep 11, 2023
b68f0c4
Merge branch 'main' into users/vivin/fix-for-other-button-focus
vivinkrishna-ni Sep 12, 2023
54c3ca0
Merge branch 'main' into users/vivin/fix-for-other-button-focus
vivinkrishna-ni Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-f4a15d51-6bb8-4ee2-8980-eb1b3325b788.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix for tabindex value change when clicked on icon of the buttons in rich text editor toolbar.",
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/nimble-components/src/rich-text/editor/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ export const styles = css`
place-items: center;
}

vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
nimble-toggle-button::part(start) {
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
pointer-events: none;
}

:host([error-visible]) .error-icon {
display: none;
}
Expand Down
Loading