Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text Editor | Angular Integration for label provider in nimble-rich-text-editor #1477

Merged
merged 26 commits into from
Sep 6, 2023
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f44331c
Add label provider for rich-text-editor
AagashRaaj Aug 28, 2023
c741e17
Fix lint
AagashRaaj Aug 28, 2023
a81799e
Change files
aagash-ni Aug 28, 2023
6c05da2
Update testcase with getSpecTypeByNamedList
aagash-ni Aug 29, 2023
3a7e724
Fix Lint
aagash-ni Aug 29, 2023
395a5aa
Minor fix
aagash-ni Aug 29, 2023
eafefaa
Address PR comments
aagash-ni Aug 29, 2023
dee5c59
Fix lint
aagash-ni Aug 29, 2023
31afcf4
Address PR Comments
aagash-ni Aug 30, 2023
8f376b9
Merge branch 'main' into users/aagash/editor-globalization
aagash-ni Aug 30, 2023
d3969e8
Merge branch 'main' into users/aagash/editor-globalization
aagash-ni Aug 30, 2023
3a5c86c
Address PR Comments
aagash-ni Aug 31, 2023
0671f0b
Fix Lint
aagash-ni Aug 31, 2023
60894e1
Merge branch 'main' of https://github.com/ni/nimble into users/aagash…
aagash-ni Aug 31, 2023
388675f
Merge branch 'main' into users/aagash/editor-globalization
aagash-ni Aug 31, 2023
7191d23
Angulation integration for rich text label provider
aagash-ni Sep 1, 2023
742eadd
Rename folder
aagash-ni Sep 1, 2023
a1b4409
Update import in app module
aagash-ni Sep 1, 2023
68a02fa
Change files
aagash-ni Sep 1, 2023
a7d2965
Minor Fix
aagash-ni Sep 1, 2023
90c792c
Address PR comments
aagash-ni Sep 4, 2023
7d98432
Address PR comments
aagash-ni Sep 5, 2023
682a434
Merge branch 'main' into users/aagash/editor-globalization-angular-in…
aagash-ni Sep 6, 2023
80d5f15
Remove chnage file
aagash-ni Sep 6, 2023
12b5a33
Merge branch 'main' into users/aagash/editor-globalization-angular-in…
aagash-ni Sep 6, 2023
6a669f5
Merge branch 'main' into users/aagash/editor-globalization-angular-in…
rajsite Sep 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address PR comments
aagash-ni committed Aug 29, 2023
commit eafefaad24c89f0a1a1284b9e3198c22221d6a29
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Canvas, Meta, Title } from '@storybook/blocks';
import { coreLabelProvider } from '../../core/tests/label-provider-core.stories';
import { tableLabelProvider } from '../../table/tests/label-provider-table.stories';
import { richTextEditorLabelProvider } from '../../rich-text-editor/tests/label-provider-rich-text-editor.stories'

<Meta title="Tokens/Label Providers" />
<Title>Label Providers</Title>
@@ -20,7 +21,7 @@ See the [Localization section of the nimble-blazor readme](https://github.com/ni

## Core Label Provider

Provides labels for all Nimble components besides the table component.
Provides labels for all Nimble components besides the table and the rich text editor component.

<Canvas of={coreLabelProvider} sourceState="none" />

@@ -29,3 +30,9 @@ Provides labels for all Nimble components besides the table component.
Provides labels for the `nimble-table` and all associated table sub-components / column types.

<Canvas of={tableLabelProvider} sourceState="none" />

## Rich Text Editor Label Provider

Provides labels for the `nimble-rich-text-editor`.

<Canvas of={richTextEditorLabelProvider} sourceState="none" />
Original file line number Diff line number Diff line change
@@ -5,3 +5,5 @@ export const ToolbarButton = {
numberedList: 3
} as const;
export type ToolbarButton = (typeof ToolbarButton)[keyof typeof ToolbarButton];

export type LabelProvider = 'toggleBold' | 'toggleItalics' | 'toggleBulletList' | 'toggleNumberedList';
Original file line number Diff line number Diff line change
@@ -7,16 +7,10 @@ import {
labelProviderRichTextEditorTag
} from '../../label-provider/rich-text-editor';
import { RichTextEditorPageObject } from '../testing/rich-text-editor.pageobject';
import { ToolbarButton } from '../testing/types';
import { LabelProvider, ToolbarButton } from '../testing/types';
import { getSpecTypeByNamedList } from '../../utilities/tests/parameterized';
import { waitForUpdatesAsync } from '../../testing/async-helpers';

type LabelProvider =
| 'toggleBold'
| 'toggleItalics'
| 'toggleBulletList'
| 'toggleNumberedList';

async function setup(): Promise<Fixture<ThemeProvider>> {
return fixture<ThemeProvider>(
html`