-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich Text Editor | Add label provider in nimble-rich-text-editor #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikisekarNI
reviewed
Aug 28, 2023
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor-labels.spec.ts
Outdated
Show resolved
Hide resolved
vikisekarNI
reviewed
Aug 28, 2023
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor-labels.spec.ts
Outdated
Show resolved
Hide resolved
vikisekarNI
reviewed
Aug 29, 2023
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor-labels.spec.ts
Outdated
Show resolved
Hide resolved
vikisekarNI
reviewed
Aug 29, 2023
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor.stories.ts
Outdated
Show resolved
Hide resolved
vikisekarNI
approved these changes
Aug 29, 2023
m-akinc
approved these changes
Aug 30, 2023
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor-labels.spec.ts
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/base/tests/label-providers.mdx
Show resolved
Hide resolved
jattasNI
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added @msmithNI as an optional reviewer since he created the label provider infrastructure. But you don't need to wait on his approval. Now that Milan's back in office, you should wait for his review though.
packages/nimble-components/src/label-provider/rich-text-editor/label-token-defaults.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/rich-text-editor/name-utils.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor-labels.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Aug 30, 2023
packages/nimble-components/src/label-provider/base/tests/label-providers.mdx
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/rich-text-editor/label-token-defaults.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/rich-text-editor/label-tokens.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/rich-text-editor/name-utils.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor-labels.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Sep 1, 2023
packages/nimble-components/src/label-provider/base/tests/label-name-utils.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/base/tests/label-name-utils.ts
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/base/tests/label-provider-stories-utils.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/label-provider/base/tests/label-provider-stories-utils.ts
Outdated
Show resolved
Hide resolved
msmithNI
approved these changes
Sep 5, 2023
rajsite
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Issue Link : #1288
Currently,
rich-text-editor
hastitle
andtext content
for formatting buttons (Bold, Italics, Bulleted List, Numbered List) and this needs to be localized from the client side.👩💻 Implementation
Reference PR for implementation: #1328
This PR creates label DesignTokens in
nimble-rich-text-editor
Note: Angular Integration will be taken up once after this PR completion.
🧪 Testing
Tokens/Label Providers
is a newRich Text Editor Label Provider
.✅ Checklist