Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich Text Editor | Fix for Editor's blinking caret disappearing issue in Firefox browser #1455

Merged
merged 16 commits into from
Aug 31, 2023
Merged

Rich Text Editor | Fix for Editor's blinking caret disappearing issue in Firefox browser #1455

merged 16 commits into from
Aug 31, 2023

Conversation

aagash-ni
Copy link
Contributor

@aagash-ni aagash-ni commented Aug 25, 2023 •
edited
Loading

Pull Request

🤨 Rationale

This PR contains workaround for resolves #1454 Firefox issue when the editor gets focused, the blinking caret will be visible until we click format buttons (Bold, Italic ...). But once any of the buttons are clicked, the editor internally has its focus but the blinking caret disappears.

Issue Link : #1454

👩‍💻 Implementation

  • Triggering Blur() and setting focus() in the editor will make the caret re-appears when clicking the formatting buttons.

🧪 Testing

  • Verified the caret visibility in the Firefox browser when clicking on the format button. Since Firefox is reporting the editor as an active element even though Caret is not rendered, manually verified this behavior.
  • Added a test case to verify the active element in the browser especially when clicking the format button.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@vikisekarNI vikisekarNI linked an issue Aug 25, 2023 that may be closed by this pull request
Rich Text Editor | Blinking caret | in editor disappears after clicking any button in Firefox browser. #1454
Closed
@aagash-ni aagash-ni requested a review from m-akinc August 25, 2023 13:15
@aagash-ni aagash-ni marked this pull request as ready for review August 28, 2023 05:17
@aagash-ni aagash-ni force-pushed the users/aagash/firefox-caret-issue branch 2 times, most recently from a81799e to c7d71c2 Compare August 29, 2023 12:49
@aagash-ni aagash-ni requested a review from jattasNI August 29, 2023 13:23
jattasNI
jattasNI approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @rajsite doesn't get to this by the time you resolve my feedback, I think it's ok to submit.

packages/nimble-components/src/rich-text-editor/index.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor.spec.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/rich-text-editor/testing/rich-text-editor.pageobject.ts Outdated Show resolved Hide resolved
@rajsite rajsite enabled auto-merge (squash) August 31, 2023 18:18
@rajsite rajsite merged commit fcc12d5 into main Aug 31, 2023
@rajsite rajsite deleted the users/aagash/firefox-caret-issue branch August 31, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikisekarNI vikisekarNI vikisekarNI approved these changes

@jattasNI jattasNI jattasNI approved these changes

@m-akinc m-akinc m-akinc approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rich Text Editor | Blinking caret | in editor disappears after clicking any button in Firefox browser.
6 participants
@aagash-ni @rajsite @m-akinc @jattasNI @vikisekarNI @AagashRaaj