Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text Editor | Bring up of editor component with toolbar support #1416

Merged
merged 79 commits into from
Aug 18, 2023
Merged

Rich Text Editor | Bring up of editor component with toolbar support #1416

Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
ca4ccec
Initial pass for editor component. This is a intermediate commit and …
vivinkrishna-ni Jul 6, 2023
6e15794
Overrides semver version to be >=7.5.2
AagashRaaj Jul 7, 2023
a163b55
Removed the tiptap packages
vivinkrishna-ni Jul 11, 2023
6df5ef1
Reverted the package-lock.json to main branch changes
vivinkrishna-ni Jul 11, 2023
38be4dd
Added tiptap packages and necessary packages for tiptap
vivinkrishna-ni Jul 11, 2023
b159f86
Component and angular skeleton code bring up for rich-text-editor
vivinkrishna-ni Jul 11, 2023
37e1062
Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use…
vivinkrishna-ni Jul 11, 2023
0d1de1a
Resolved linting errors
vivinkrishna-ni Jul 11, 2023
91362df
Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use…
vivinkrishna-ni Jul 11, 2023
70a5c2d
Removed angular code from this branch and will be added as separate PR
vivinkrishna-ni Jul 11, 2023
0a68e83
Removed constant file file for rich-text-content
vivinkrishna-ni Jul 11, 2023
6bdd0d7
Change files
vivinkrishna-ni Jul 11, 2023
5851a8b
Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use…
vivinkrishna-ni Jul 11, 2023
391ecbc
Updated the description for editor storybook
vivinkrishna-ni Jul 11, 2023
288aa3e
Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use…
vivinkrishna-ni Jul 11, 2023
43330c2
Merge branch 'main' into users/vivin/initial-code-for-rich-text-editor
vivinkrishna-ni Jul 13, 2023
f21a11e
Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use…
vivinkrishna-ni Jul 13, 2023
4c94bd4
Initial bring up of titptap editor with basic template enabled
vivinkrishna-ni Jul 14, 2023
6cc6209
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Jul 18, 2023
560ecd5
Intermediate commit to add functionalities to the buttons and modifie…
vivinkrishna-ni Jul 19, 2023
a32ade0
Added placeholder and link extensions
vivinkrishna-ni Jul 20, 2023
dc8152d
Added placeholder support rich-text-editor
vivinkrishna-ni Jul 20, 2023
00571c1
Updates on the link configurations
vivinkrishna-ni Jul 21, 2023
0468ba5
Intermediate changes for maxlength and disabled state
vivinkrishna-ni Jul 25, 2023
9ec89cf
Updated for footer hidden attribute
vivinkrishna-ni Jul 26, 2023
d56355b
Added some additional APIs to this branch, might be removed and split…
vivinkrishna-ni Jul 31, 2023
33cb3c7
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Jul 31, 2023
efe79e0
Update package lock json
vivinkrishna-ni Jul 31, 2023
ca2bf70
Changes with only basic editor and footer actions
vivinkrishna-ni Jul 31, 2023
1c39203
Updated few code changes to re-confirm pipeline passes
vivinkrishna-ni Aug 1, 2023
390df6a
Removed markdown-it from dev dependency
vivinkrishna-ni Aug 1, 2023
92ddd09
Updated test case, style and implementation to integrate tiptap edito…
vivinkrishna-ni Aug 2, 2023
e0e20eb
Update desc in change file and formatting in template
vivinkrishna-ni Aug 3, 2023
3df5015
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 3, 2023
fe4b926
resolve linting errors
vivinkrishna-ni Aug 3, 2023
bd29abb
Changed the name of the private function and minor style change
vivinkrishna-ni Aug 3, 2023
15b3fa4
Added model class for editor button events
vivinkrishna-ni Aug 3, 2023
9dc2e1a
returning void for base class methods
vivinkrishna-ni Aug 3, 2023
e67d478
resolve linting errors
vivinkrishna-ni Aug 3, 2023
40633b8
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 4, 2023
4d3e099
Resolved PR comments
vivinkrishna-ni Aug 7, 2023
ad024ef
Added internal comment for public variables
vivinkrishna-ni Aug 7, 2023
bbe0c26
Resolve PR comments
vivinkrishna-ni Aug 7, 2023
6dddc0a
Update minor function name change
vivinkrishna-ni Aug 7, 2023
94cafd0
resolve linting errors
vivinkrishna-ni Aug 7, 2023
c1a0ca8
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 8, 2023
0b16f24
Updated package-lock.json
vivinkrishna-ni Aug 9, 2023
9eb96e3
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 9, 2023
21abec6
Resolving PR comments
vivinkrishna-ni Aug 9, 2023
efa3f1e
Updated the name for button properties and resolve linting errors
vivinkrishna-ni Aug 9, 2023
101ebb5
Added test cases for aria attributes
vivinkrishna-ni Aug 9, 2023
2602635
Removed fdescribe
vivinkrishna-ni Aug 9, 2023
393f42b
Added comments to specify the return value for key handler
vivinkrishna-ni Aug 9, 2023
462d929
added readonly for base class properties
vivinkrishna-ni Aug 9, 2023
8e33326
Removed model classes and moved it to a template file
vivinkrishna-ni Aug 10, 2023
2755e60
Added labels for each buttons
vivinkrishna-ni Aug 10, 2023
d0bfce2
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 11, 2023
367491e
Resolving PR comments
vivinkrishna-ni Aug 11, 2023
2b01fff
Minor code changes
vivinkrishna-ni Aug 11, 2023
1ece855
Updated comment in the code
vivinkrishna-ni Aug 11, 2023
54cfba0
updated the comment in the styles
vivinkrishna-ni Aug 11, 2023
65bd029
resolve linting errors
vivinkrishna-ni Aug 11, 2023
04db1a8
Added test cases for the change event propagation and part for footer…
vivinkrishna-ni Aug 11, 2023
d8c239e
Minor correction in the comment added
vivinkrishna-ni Aug 11, 2023
9d21139
Added test cases for nested lists in editor and viewer
vivinkrishna-ni Aug 14, 2023
7c5c95e
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 14, 2023
47e92d7
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 14, 2023
9f27b34
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 14, 2023
cd43757
Minor test case name update
vivinkrishna-ni Aug 15, 2023
1daf767
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 15, 2023
aa4045c
Refactored page object and updated the test cases accordingly
vivinkrishna-ni Aug 16, 2023
567fd0c
Updated the nested list test cases in viewer component
vivinkrishna-ni Aug 16, 2023
ef70cda
Resolving PR comments
vivinkrishna-ni Aug 17, 2023
dfb9cd8
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 17, 2023
f211efc
Updated the default height of the container for sizing tests
vivinkrishna-ni Aug 17, 2023
afe3cdf
Merge branch 'users/vivin/integrate-tiptap-editor' of https://github.…
vivinkrishna-ni Aug 17, 2023
31cac04
Added titles for buttons and moved enum to a type file
vivinkrishna-ni Aug 18, 2023
8db2b7f
Added spec file for types
vivinkrishna-ni Aug 18, 2023
0b58903
Merge branch 'main' into users/vivin/integrate-tiptap-editor
vivinkrishna-ni Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-e476eedb-989a-4246-811b-039ca8a8352e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"comment": "Initial component bring up by integrating tiptap editor along with the footer formatting options",
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Loading