Spec update to include absolute URL support for rich text editor #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/ni/nimble into users/vivin/spec-update-for-placeholder
…hub.com/ni/nimble into users/vivin/spec-update-for-placeholder
…hub.com/ni/nimble into users/vivin/spec-update-for-placeholder
rajsite
reviewed
Aug 16, 2023
…ewer Signed-off-by: Vignesh A S <[email protected]>
vikisekarNI
approved these changes
Aug 28, 2023
|
Friendly reminder that you should click "re-request review" when you've addressed reviewers feedback and want them to weigh in again. This is helpful because GitHub offers ways for reviewers to filter PRs by the ones that are awaiting our input, but PRs won't show up in that filter if you don't re-request. I already did this for the reviewers that needed it on this PR, just a tip for the future!
|
jattasNI
reviewed
Aug 28, 2023
packages/nimble-components/src/rich-text-editor/specs/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Vignesh A S <[email protected]>
…/ni/nimble into users/vivin/spec-update-for-link
jattasNI
approved these changes
Aug 30, 2023
|
I will pester the remaining Nimble reviewers tomorrow to submit their feedback. |
mollykreis
approved these changes
Aug 30, 2023
|
I will decline to review. |
m-akinc
reviewed
Aug 30, 2023
m-akinc
reviewed
Aug 30, 2023
m-akinc
approved these changes
Aug 30, 2023
rajsite
approved these changes
Aug 30, 2023
rajsite
reviewed
Aug 30, 2023
packages/nimble-components/src/rich-text-editor/specs/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Vignesh A S <[email protected]>
Signed-off-by: Vignesh A S <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As a requirement for the comments feature, we need to support absolute URL links in both the
nimble-rich-text-editorandnimble-rich-text-viewercomponents. Therefore, I am initiating this PR to add the necessary support for absolute URL links in the editor and viewer.Related discussion on link support: #1369 (comment)
👩💻 Implementation
Updated spec to add information on the design for supporting absolute URL links in a rich text editor and viewer components.
🧪 Testing
✅ Checklist