Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code bring up of nimble-rich-text-viewer component #1314

Merged
merged 67 commits into from
Jun 28, 2023
Merged

Initial code bring up of nimble-rich-text-viewer component #1314

merged 67 commits into from
Jun 28, 2023

Conversation

vivinkrishna-ni
Copy link
Contributor

@vivinkrishna-ni vivinkrishna-ni commented Jun 20, 2023 •
edited
Loading

Pull Request

🤨 Rationale

This PR includes the initial bring-up of the nimble-rich-text-viewer component to get started with the development. The actual functionality of the component will be created in separate PRs.

👩‍💻 Implementation

  • Creates a nimble-rich-text-viewer component that renders the string Rich Text Viewer here.
  • Create a storybook story for nimble-rich-text-viewer with the warning message as it is in the incubating state.
  • Adds the component in the component status table with ⚠️status.
  • Create a unit test that verifies the nimble-rich-text-viewer element can be viewed.
  • Create matrix tests for the basic rendering of the component in different themes and hidden rich text viewer.

🧪 Testing

  • Locally verified the component on the storybook page.
  • Ran unit tests.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

vivinkrishna-ni and others added 30 commits June 8, 2023 11:59
@vivinkrishna-ni
Initial nimble spec of the rich text editor and viewer component
f14ee94
@vivinkrishna-ni
Corrected the header name of the spec
8362d19
@vivinkrishna-ni
Change files
b22cbb7
@vivinkrishna-ni
Updated the supported features in feature section.
129dcf1
@vivinkrishna-ni
Resolved some of the PR comments
4e5ff60
@vivinkrishna-ni
Removed few methods as it is not required.
217e4f1
@vivinkrishna-ni
Resolve some of the PR comments
a95970b
@vivinkrishna-ni
Updated the template for rich text editor
a26b2a4
@vivinkrishna-ni
Resolved some of the PR comments and made update to some design changes.
d9abc1d
@vivinkrishna-ni
Resolving PR comments on updating the doc on implementation and secur…
acd0f22 
…ity section.
@vivinkrishna-ni
Corrected the sentence in non goals section
7251bba
@vivinkrishna-ni
Corrected the sentence in API section.
3e03f12
@vivinkrishna-ni
Spell check in the implementation part.
b8ed166
@vivinkrishna-ni
Sentence correction in accessability.
a11e16f
@vivinkrishna-ni
Made few changes to doc as suggested
e9ea50d
@vivinkrishna-ni
noreply email update
3727587
@vivinkrishna-ni
Resolved some of the PR comments in rich-text-editor and viewer spec
2e5c8c5
@vivinkrishna-ni
Corrected minor changes.
afa0744
@vivinkrishna-ni
Updated the title of the viewer
6eb5829
@vivinkrishna-ni
Updated a point in the API events section
c831c23
@vivinkrishna-ni
Updated the spec images as per the new mockup screens
056e664
@vivinkrishna-ni
Added CSS design for both editor and viewer component
c2d64ba
@vivinkrishna-ni
Resolved minor corrections in the spec
429d3b0
@vivinkrishna-ni
Updated the comments UI mockup link
ecb1890
@vivinkrishna-ni
Corrected the risks and challenges points
455d8a6
@vivinkrishna-ni
Updated the template and made few corrections in CSS design
ad6eca5
@vivinkrishna-ni
Updated the description in Non-goals section
35a9b5b
@vivinkrishna-ni
Made few changes to the spec.
9aee11f
@vivinkrishna-ni
Updated the API section for both the components
539b01d
@vivinkrishna-ni
Resolved some of the corrections in the spec
c7a75d0
@vivinkrishna-ni vivinkrishna-ni changed the base branch from main to rich-text-editor-viewer-spec June 22, 2023 08:02
@jattasNI jattasNI mentioned this pull request Jun 27, 2023
Merged
Base automatically changed from rich-text-editor-viewer-spec to main June 27, 2023 14:23
@rajsite
Copy link
Member

rajsite commented Jun 27, 2023 •
edited
Loading

@vivinkrishna-ni Looks like there is a couple comments to address and the only remaining reviewer for this PR to merge is @suseendran-ni

@vivinkrishna-ni vivinkrishna-ni enabled auto-merge (squash) June 28, 2023 13:04
@vivinkrishna-ni vivinkrishna-ni merged commit c88e365 into main Jun 28, 2023
@vivinkrishna-ni vivinkrishna-ni deleted the users/vivin/rich-text-viewer branch June 28, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI jattasNI approved these changes

@vikisekarNI vikisekarNI vikisekarNI approved these changes

@suseendran-ni suseendran-ni suseendran-ni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivinkrishna-ni @rajsite @jattasNI @vikisekarNI @suseendran-ni