Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimble Rich Text Editor and Viewer Spec Document #1289

Merged
merged 45 commits into from
Jun 27, 2023
Merged

Nimble Rich Text Editor and Viewer Spec Document #1289

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
f14ee94
Initial nimble spec of the rich text editor and viewer component
vivinkrishna-ni Jun 8, 2023
8362d19
Corrected the header name of the spec
vivinkrishna-ni Jun 8, 2023
b22cbb7
Change files
vivinkrishna-ni Jun 8, 2023
129dcf1
Updated the supported features in feature section.
vivinkrishna-ni Jun 8, 2023
4e5ff60
Resolved some of the PR comments
vivinkrishna-ni Jun 8, 2023
217e4f1
Removed few methods as it is not required.
vivinkrishna-ni Jun 8, 2023
a95970b
Resolve some of the PR comments
vivinkrishna-ni Jun 8, 2023
a26b2a4
Updated the template for rich text editor
vivinkrishna-ni Jun 8, 2023
d9abc1d
Resolved some of the PR comments and made update to some design changes.
vivinkrishna-ni Jun 9, 2023
acd0f22
Resolving PR comments on updating the doc on implementation and secur…
vivinkrishna-ni Jun 9, 2023
7251bba
Corrected the sentence in non goals section
vivinkrishna-ni Jun 9, 2023
3e03f12
Corrected the sentence in API section.
vivinkrishna-ni Jun 9, 2023
b8ed166
Spell check in the implementation part.
vivinkrishna-ni Jun 9, 2023
a11e16f
Sentence correction in accessability.
vivinkrishna-ni Jun 9, 2023
e9ea50d
Made few changes to doc as suggested
vivinkrishna-ni Jun 9, 2023
3727587
noreply email update
vivinkrishna-ni Jun 11, 2023
2e5c8c5
Resolved some of the PR comments in rich-text-editor and viewer spec
vivinkrishna-ni Jun 12, 2023
afa0744
Corrected minor changes.
vivinkrishna-ni Jun 13, 2023
6eb5829
Updated the title of the viewer
vivinkrishna-ni Jun 13, 2023
c831c23
Updated a point in the API events section
vivinkrishna-ni Jun 13, 2023
056e664
Updated the spec images as per the new mockup screens
vivinkrishna-ni Jun 13, 2023
c2d64ba
Added CSS design for both editor and viewer component
vivinkrishna-ni Jun 13, 2023
429d3b0
Resolved minor corrections in the spec
vivinkrishna-ni Jun 13, 2023
ecb1890
Updated the comments UI mockup link
vivinkrishna-ni Jun 13, 2023
455d8a6
Corrected the risks and challenges points
vivinkrishna-ni Jun 13, 2023
ad6eca5
Updated the template and made few corrections in CSS design
vivinkrishna-ni Jun 14, 2023
35a9b5b
Updated the description in Non-goals section
vivinkrishna-ni Jun 14, 2023
9aee11f
Made few changes to the spec.
vivinkrishna-ni Jun 14, 2023
539b01d
Updated the API section for both the components
vivinkrishna-ni Jun 14, 2023
c7a75d0
Resolved some of the corrections in the spec
vivinkrishna-ni Jun 15, 2023
a09401f
Resolved some of the PR comments
vivinkrishna-ni Jun 15, 2023
1d86bf6
Updated the API to check the isEmpty value
vivinkrishna-ni Jun 15, 2023
f3d834d
Updated the styling part of the component
vivinkrishna-ni Jun 15, 2023
f0049d3
Updated the style information for viewer component.
vivinkrishna-ni Jun 15, 2023
1651461
Updated the package size information to the dependencies
vivinkrishna-ni Jun 16, 2023
2490c80
Updated the spec as per the suggestion.
vivinkrishna-ni Jun 19, 2023
9c89946
Updated the spec
vivinkrishna-ni Jun 19, 2023
1a4191a
Merge branch 'main' into rich-text-editor-viewer-spec
vivinkrishna-ni Jun 19, 2023
6cfd408
Merge branch 'main' into rich-text-editor-viewer-spec
vivinkrishna-ni Jun 21, 2023
92025d3
Updated the sizing changes for editor and viewer component.
vivinkrishna-ni Jun 21, 2023
d75a1a3
Resolved linting errors
vivinkrishna-ni Jun 21, 2023
bff8d5b
Added information on the Angular implementation
vivinkrishna-ni Jun 22, 2023
53841a7
Merge branch 'main' into rich-text-editor-viewer-spec
vivinkrishna-ni Jun 23, 2023
7007a3b
Updated the spec by removing the hyperlink support for the initial re…
vivinkrishna-ni Jun 26, 2023
4a10729
Merge branch 'main' into rich-text-editor-viewer-spec
vivinkrishna-ni Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-02d33e01-7578-482d-aa7f-8f592617a882.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"comment": "Add spec document for nimble rich text editor and nimble rich text viewer",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
405 changes: 405 additions & 0 deletions packages/nimble-components/src/rich-text-editor/specs/README.md
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added packages/nimble-components/src/rich-text-editor/specs/spec-images/button-state.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ages/nimble-components/src/rich-text-editor/specs/spec-images/editor-sample.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ages/nimble-components/src/rich-text-editor/specs/spec-images/viewer-sample.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/nimble-components/src/rich-text-viewer/specs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Nimble Rich Text Viewer

The spec of this component is added as part of the [`/rich-text-editor/specs/README.md`](../../rich-text-editor/specs/README.md)