Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Intermittent test failures in firefox #2491

Open
mollykreis opened this issue Dec 9, 2024 · 0 comments
Open

[Table] Intermittent test failures in firefox #2491

mollykreis opened this issue Dec 9, 2024 · 0 comments
Assignees
@msmithNI
Labels
bug Something isn't working

Comments

@mollykreis
Copy link
Contributor

mollykreis commented Dec 9, 2024 •
edited by m-akinc
Loading

🐛 Bug Report

There are test failures in Firefox associated with the nimble-table. See this test run

Failure excerpts:

[test-concurrent:nimble-components] [test-firefox] 1) updates scroll position if data length is reduced while not attached
[test-concurrent:nimble-components] [test-firefox]      Table detaching and reattaching
[test-concurrent:nimble-components] [test-firefox]      Expected 0 to be greater than 0.
[test-concurrent:nimble-components] [test-firefox] 2) maintains scroll position if data does not change
[test-concurrent:nimble-components] [test-firefox]      Table detaching and reattaching
[test-concurrent:nimble-components] [test-firefox]      Expected 0 to be 6352.
[test-concurrent:nimble-components] [test-firefox] 3) adjusts the number of rendered rows when the table height decreases while not attached
[test-concurrent:nimble-components] [test-firefox]      Table detaching and reattaching
[test-concurrent:nimble-components] [test-firefox]      Expected 18 to be less than 18.

Added three more tests related to the table that I saw fail on Firefox.

[test-concurrent:nimble-components] [test-firefox]   Table
[test-concurrent:nimble-components] [test-firefox]     detaching and reattaching
[test-concurrent:nimble-components] [test-firefox]       - updates scroll position if data length is reduced while not attached #SkipFirefox (0ms)
[test-concurrent:nimble-components] [test-firefox]       - maintains scroll position if data does not change #SkipFirefox (0ms)
[test-concurrent:nimble-components] [test-firefox]       ✗ maintains scroll position if data length is increased while not attached (1283ms)
[test-concurrent:nimble-components] [test-firefox] 	Expected 0 to be 6352.


[test-concurrent:nimble-components] [test-firefox]   Table Column Sizing
[test-concurrent:nimble-components] [test-firefox]     columns/cells are sized correctly after scrolling vertically
[test-concurrent:nimble-components] [test-firefox]       ✗ when columns have fractional widths (12918ms)
[test-concurrent:nimble-components] [test-firefox] 	Error: Timeout - Async function did not complete within 10000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) in /home/runner/work/nimble/nimble/node_modules/karma-jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 7612)
[test-concurrent:nimble-components] [test-firefox] 
[test-concurrent:nimble-components] [test-firefox]     table column size changes result in correct rendered widths
[test-concurrent:nimble-components] [test-firefox]       ✗ second column set to use pixelWidth (89ms)
[test-concurrent:nimble-components] [test-firefox] 	Error: Attempting to index past the total number of rendered rows in /tmp/_karma_webpack_798083/commons.js (line 109158)

Failure excerpt:

💻 Repro or Code Sample

🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

🔦 Context

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@mollykreis mollykreis added bug Something isn't working triage New issue that needs to be reviewed labels Dec 9, 2024
@mollykreis mollykreis mentioned this issue Dec 9, 2024
Merged
1 task
mollykreis added a commit that referenced this issue Dec 11, 2024
@mollykreis @jattasNI
Disable failing tests in Firefox (#2489)
1752793 
# Pull Request

## 🤨 Rationale

Disabling tests that I saw failing on an unrelated pipeline

Issues have been created to track these failing tests: #2488, #2490,
#2491

## 👩‍💻 Implementation

N/A

## 🧪 Testing

N/A

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Jesse Attas <[email protected]>
@m-akinc m-akinc mentioned this issue Jan 15, 2025
Merged
1 task
m-akinc added a commit that referenced this issue Jan 16, 2025
@m-akinc
Disable a couple Table tests intermittent on Firefox (#2514)
a4011ec 
# Pull Request

## 🤨 Rationale

Ran into a couple intermittent tests, so disabling them.

## 👩‍💻 Implementation

Added `#SkipFirefox` tag to test name and added comment linking to issue
(#2491)

## 🧪 Testing

N/A

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@m-akinc m-akinc changed the title [Table] Test failures in firefox [Table] Intermittent test failures in firefox Jan 23, 2025
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jan 23, 2025
@msmithNI msmithNI self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msmithNI msmithNI

Labels
bug Something isn't working
Projects
Nimble Design System Priorities
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-akinc @mollykreis @msmithNI