minor clean up

ni · Dec 12, 2024 · 5e6bf30 · 5e6bf30
1 parent 7432453
commit 5e6bf30
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/packages/nimble-components/src/combobox/tests/combobox.spec.ts b/packages/nimble-components/src/combobox/tests/combobox.spec.ts
@@ -109,15 +109,13 @@ describe('Combobox', () => {
             expect(element.control.getAttribute('disabled')).not.toBeNull();
         });
 
-        it('should set "aria-required" to true when "required-visible" is true', async () => {
-            await connect();
+        it('should set "aria-required" to true when "required-visible" is true', () => {
             element.requiredVisible = true;
             processUpdates();
             expect(element.control.getAttribute('aria-required')).toBe('true');
         });
 
-        it('should set "aria-required" to false when "required-visible" is false', async () => {
-            await connect();
+        it('should set "aria-required" to false when "required-visible" is false', () => {
             element.requiredVisible = false;
             processUpdates();
             expect(element.control.getAttribute('aria-required')).toBe('false');

diff --git a/packages/nimble-components/src/radio-group/tests/radio-group.spec.ts b/packages/nimble-components/src/radio-group/tests/radio-group.spec.ts
@@ -16,6 +16,7 @@ describe('Radio Group', () => {
 
     beforeEach(async () => {
         ({ element, connect, disconnect } = await setup());
+        await connect();
     });
 
     afterEach(async () => {
@@ -28,15 +29,13 @@ describe('Radio Group', () => {
         );
     });
 
-    it('should set "aria-required" to true when "required-visible" is true', async () => {
-        await connect();
+    it('should set "aria-required" to true when "required-visible" is true', () => {
         element.requiredVisible = true;
         processUpdates();
         expect(element.getAttribute('aria-required')).toBe('true');
     });
 
-    it('should set "aria-required" to false when "required-visible" is false', async () => {
-        await connect();
+    it('should set "aria-required" to false when "required-visible" is false', () => {
         element.requiredVisible = false;
         processUpdates();
         expect(element.getAttribute('aria-required')).toBe('false');

diff --git a/packages/storybook/src/utilities/storybook.ts b/packages/storybook/src/utilities/storybook.ts
@@ -197,7 +197,7 @@ export const placeholderDescription = (options: {
 export const errorTextDescription = 'A message to be displayed explaining why the value is invalid. Only visible when `error-visible` is set.';
 export const errorVisibleDescription = 'When set to `true`, an error indicator will be displayed within the control and the `error-text` message will be displayed.';
 
-export const requiredVisibleDescription = 'When set to `true`, an indicator will be displayed within the control to indicate that the field is required. A control should not set `required-visible` on disabled or readonly controls.';
+export const requiredVisibleDescription = 'When set to `true`, an indicator will be displayed within the control to indicate that the field is required. A disabled or readonly control should not also be marked as `required-visible`.';
 
 export const dropdownPositionDescription = (options: {
     componentName: string